fix(deps): update and pin react-i18next to 14.0.2
#7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egression in that library
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
runeb
changed the title
|
No changes to documentation |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Component Testing Report Updated Aug 13, 2024 1:17 AM (UTC)
|
ricokahler
approved these changes
Aug 13, 2024
rexxars
changed the title
react-i18next to 14.0.2
rexxars
approved these changes
Aug 13, 2024
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
Fixes a performance issue caused by an older version of the library
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our dependency for translations,
react-i18nexthas an open performance regression caused by multiple re-renders fromuseTranslationi18next/react-i18next#1756
As one maintainer mentiones, this issue was fixed in version
14.0.2of that library, a fix they later rolled back because it broke changing of languages at runtime:i18next/react-i18next#1756 (comment)
Since we currently do not support changing languages, I suggest we pin to
14.0.2until the library is fixed properly in more current versions.What to review
That the version we upgraded to is still compatible with the way we use their API. They seem to bump major versions for fixes and type changes.
https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md
Testing
I manually profiled the application and found that random re-renders due to
useTranslationhook were not present in the same way they were before this version change.Notes for release
Pin
react-i18nextto version14.0.2to address potential performance regression in that library